[Identity] Fix PowershellCredential token parsing logic #30508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarishmaGhiya
requested review from
maorleger,
schaabs and
a team
as code owners
KarishmaGhiya
requested review from
christothes,
pvaneck,
g2vinay,
ahsonkhan and
mpodwysocki
KarishmaGhiya
changed the title
|
API change check API changes are not detected in this pull request. |
xirzec
reviewed
Jul 23, 2024
sdk/identity/identity/src/credentials/azurePowerShellCredential.ts
Outdated
Show resolved
Hide resolved
xirzec
reviewed
Jul 23, 2024
xirzec
reviewed
Jul 23, 2024
sdk/identity/identity/src/credentials/azurePowerShellCredential.ts
Outdated
Show resolved
Hide resolved
maorleger
reviewed
Jul 24, 2024
sdk/identity/identity/test/internal/node/azurePowerShellCredential.spec.ts
Outdated
Show resolved
Hide resolved
maorleger
approved these changes
Jul 24, 2024
jeremymeng
reviewed
Jul 25, 2024
sdk/identity/identity/src/credentials/azurePowerShellCredential.ts
Outdated
Show resolved
Hide resolved
KarishmaGhiya
added a commit
to KarishmaGhiya/azure-sdk-for-js
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/identity
Issues associated with this PR
Describe the problem that is addressed by this PR
We will do both in case we don't want to suppress few warnings (future-proofing solutions)
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
In this PR, I am essentially making the token parsing logic more robust to account for all strings and multiple json objects, carefully pick the correct json for the access token and log the rest of the output as warning with the logger.
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists